Derivative name in file name

aglushkov · November 30, 2019, 10:21pm

I add #generate_location(io, context) method to change file name and wanted to add derivative name to path.

When creating derivative in cache storage context receives value for example {derivative: :thumb}
But when promoting - {derivative: [:thumb]} (array value)

Distiction is in this to methods, where one uses derivative_path(path)

github.com

shrinerb/shrine/blob/8f3fe5acf2b1aad462b033b2d62822fe61a395f6/lib/shrine/plugins/derivatives.rb#L228-L234


def upload_derivatives(files, **options)
  map_derivative(files) do |path, file|
    path = derivative_path(path)


    upload_derivative(path, file, **options)
  end
end

github.com

shrinerb/shrine/blob/8f3fe5acf2b1aad462b033b2d62822fe61a395f6/lib/shrine/plugins/derivatives.rb#L153-L160


def promote_derivatives(**options)
  stored_derivatives = map_derivative(derivatives) do |path, derivative|
    if cached?(derivative)
      upload_derivative(path, derivative, **options)
    else
      derivative
    end
  end

janko · November 28, 2019, 9:15am

Hi, thanks for reporting and finding the root cause. I’ve just pushed a fix to master.